1558100 - Higth memory and CPU usage when playing video in bilibili.com

Status: VERIFIED FIXED

(Core :: Graphics: WebRender, defect, P2)

Description

[nayinain]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:69.0) Gecko/20100101 Firefox/69.0

Steps to reproduce:

1. Open a clean Profile.
2. Open https://www.bilibili.com/video/av54754681/
3. Play the video in the page for a while.

Actual results:

Higth memory and CPU usage

Expected results:

---

Sorry for my bad English.

Comment 1

[nayinain]

2019-06-10T12:41:12: INFO : Narrowed inbound regression window from [42622b5a, bbab037b] (3 builds) to [ef0b9879, bbab037b] (2 builds) (~1 steps left)
2019-06-10T12:41:12: DEBUG : Starting merge handling...
2019-06-10T12:41:12: DEBUG : Using url: https://hg.mozilla.org/integration/autoland/json-pushes?changeset=bbab037b0f9fc6e460e62e3f4da98e984f83714b&full=1
2019-06-10T12:41:13: DEBUG : Found commit message:
Bug 1556340 - Make D3D11TextureData and DXGIYCbCrTextureData alive during host side usage with WebRender r=nical

By Bug 1555544 , it became clear that D3D11TextureData and DXGIYCbCrTextureData should not be deleted before calling >>RenderDXGITextureHostOGL::EnsureLockable() / RenderDXGITextureHostOGL::EnsureLockable().

With WebRender, the EnsureLockable()s are called on RenderThread asynchronously. Then for achieving the above, it is simpler just to keep >>D3D11TextureData and DXGIYCbCrTextureData alive during host side usage.

There is already a mechanism to do it. By using NotifyNotUsed, it could be done.

Differential Revision: https://phabricator.services.mozilla.com/D33469

2019-06-10T12:41:13: DEBUG : Did not find a branch, checking all integration branches
2019-06-10T12:41:13: INFO : The bisection is done.
2019-06-10T12:41:14: INFO : Stopped

Comment 2

[Sotaro Ikeda [:sotaro]]

The following TextureClient is not recycled, it might be related.
https://searchfox.org/mozilla-central/source/gfx/layers/client/CanvasClient.cpp#115

Comment 3

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1558100 - Recycle TextureClient in CanvasClient2D with WebRender

Comment 4

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e711d803ddcaa371bf1d027a607e82d4c3cb9a00

https://treeherder.mozilla.org/perf.html#/compare?originalProject=try&originalRevision=6d581679c4f4868ff67c96ef3c19e5fe9f979ca9&newProject=try&newRevision=d6696355098cb147ca02f874f7e55ebf09a26bac

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ff570f169670
Recycle TextureClient in CanvasClient2D with WebRender r=nical

Comment 6

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/ff570f169670

Comment 7

[lolipopplus]

Can you merge this change to beta so that this bug won't hit release? I can guarantee that this site is VERY popular in China.

Among teenagers, it has even more than 80% coverage.

Comment 8

[Darkspirit]

This regression was caused by bug 1556340 within Nightly 69, thus Beta 68 should not be affected. Does Beta have a problem on this website?
Or do you want to imply bug 1556340 should be uplifted to Beta as well?

Comment 9

[lolipopplus]

Does Beta have a problem on this website?

I believe so

but I'm bot sure about D3D11TextureData

Comment 13

[Florin Strugariu [:Bebe]]

== Change summary for alert #21525 (as of Wed, 19 Jun 2019 05:52:34 GMT) ==

Improvements:

16% raptor-motionmark-animometer-firefox linux64-shippable-qr opt 41.30 -> 47.85
11% raptor-motionmark-animometer-firefox windows10-64-shippable-qr opt 39.42 -> 43.58
10% raptor-motionmark-animometer-firefox windows10-64-shippable-qr opt 39.52 -> 43.64

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=21525

Comment 14

[Alexandru Trif, Desktop QA [:atrif]]

Hello,
Reproduced the issue using Firefox 69.0a1 (20190609214350) on Windows 10x64. After playing the video for a while the CPU and memory usage increased drastically.
The issue is verified fixed with Firefox 69.0b8 (20190725174626) on Windows 10x64, Ubuntu 18.04, macOS 10.14. The CPU and memory usage remains at normal values after playing the video some time while using WebRender.

Comment 15

[Alexandru Trif, Desktop QA [:atrif]]

Updating the flag for 69.0b8. Sorry for the mistake.